|
Post by t0pel on Sept 11, 2019 18:57:45 GMT
Hi, I have just released a new version of the app that adds various improvements: - Adds option to create a "Quick Character" that is optimized for the very hard first book
- Makes text entry instructions more clear (i.e. in book 1 section 51)
- Books can now be redownloaded in case some files are missing
- Adds multiple small fixes to improve stability
You can download the update from Google Play Store or via the link on the website. Enjoy the update and let me know if you encounter any problems, I will fix them ASAP. Good luck and have fun! t0pel
|
|
|
Post by Ofecks on Sept 11, 2019 22:30:10 GMT
Hey t0pel, I'm currently trying out your Android app and have been noting possible bugs and other things in preparation for a large effort post once I complete a full run (21-28). It'll be similar to what I did with Lone Wolf Saga over in that thread. Just letting you know. Enjoying the app so far!
|
|
|
Post by t0pel on Sept 11, 2019 23:06:37 GMT
Hey t0pel, I'm currently trying out your Android app and have been noting possible bugs and other things in preparation for a large effort post once I complete a full run (21-28). It'll be similar to what I did with Lone Wolf Saga over in that thread. Just letting you know. Enjoying the app so far! Thank you, that is much appreciated! Let me know what you find, please.
|
|
|
Post by Ofecks on Oct 10, 2019 1:10:44 GMT
Hello, I've finished a successful New Order campaign via your app and would like to provide some feedback. For the most part, I found it to be a high-quality and polished piece of software, but I did come across a few bugs and questionable interpretations of rules.
I have experience using Seventh Sense/S and Lone Wolf Saga so I compared your app to those.
Also, any direct references to book sections will be in parenthesis as such: (x:y, z, a, b, c, etc) Where X is the book number and Y/Z/A/B/C/etc are the section numbers.
As for the hardware, I used this app on a Samsung Galaxy J7-Perx phone with Android version 8.1. If you need any other info about my phone and its software, please let me know.
All settings in LWNO were left as default except I enabled cloud save backups.
Major General Issue - Missing Section Text Your app seems to have an issue with indented paragraphs in the book sections. These are typically used by PA for item lists, riddles, etc. With only one exception that I found, the issue is that they don't appear in the app's section text at all! The buying/selling interface seems to work correctly but I found the missing text to be erroneous and confusing to gameplay. I will note all of those that I found below (there are likely many more sections, in addition to these, that need to be fixed): (21:142, 7, 40) (22:152, 61, 308, 167, 206, 156, 278) (23:246, 259, 120, 166, 211) (24:237, 79, 292, 274, 286, 148) (25:101, 333) (26:238, 330, 144, 138) (27:80, 311) (28:237, 87) (28:192) The list of items is actually present here, but it is in the wrong place in the text: it is immediately preceeding the section options instead of mid-section where it belongs.
Sunstrike Bonuses The Kai Weapon Sunstrike appears to be bugged. Its standard +5 CS Kai Weapon bonus works correctly, but choosing it bestows an additional, permanent, +1 bonus in, what seems to be, every single combat, regardless of time of day, or even possessing the weapon at all! This is on top of the somewhat-correctly-implemented intended bonus that applies during daytime fights. Thus, using the weapon oftentimes gives a +7 total bonus, which is erroneous. Since the permanent bonus seems to affect all combats, I will only note below the sections in which I found the intended bonus is not working correctly: (21:266, 300) it is nighttime in these sections yet the bonus for wielding Sunstrike is applied (24:24, 160) same as above, it is nighttime here
This Kai Weapon (and likely others) needs a full coding review. I did not check the intended daytime bonus of Sunstrike in every combat: as stated above, I only found inconsistencies in books 21 and 24, two combats in each. While Dever does explicitly indicate some Kai Weapon additional bonuses in later books, a context review for the others should be done.
Forced Item, Discipline, and Currency Use The freedom your app gives to NOT use or apply something should a section call for it is very welcome, as Seventh Sense forces you to use things that you possess, leading to a very strict, rail-roaded-type of gameplay. However, I've noted 3 instances in your app where an action is forced when it should be a choice, which is inconsistent with your established rules: (24:340) I was forced to use the bomb here. (27:181) I was forced to pay the Gold for the robes. (27:130) I had Eye of Lhaz here but not Animal Mastery, and I was forced to use it.
Other General Issues - Your app has no safekeeping functionality. This matches the logistics of books 22 and 23, but several books begin from the Kai Monastery, where you could store useful items for later use. - When choosing your Disciplines at the start of each book, there is an erroneous "2" following "Kai Weapon" towards the end of the section text. It is presumably a remnant of the PA footnote containing details about Kai Weapons. - The name of the Kai-Alchemy or Magi-magic spell in any section in which is it used should be italicised, per PA formatting standards. - There is a text bug in the confirmation when dropping items - it reads: "This _actionButton cannot be undone!" - Dropping Special or Backpack items doesn't update the order numbers in the list immediately, it needs a page reload to do so. - Lists of items in the buy/sell/acquire interface do not indicate Special Item status, if applicable. - Tapping a Discipline in the Stats menu should give a description of the discipline and list its improvements (currently it does nothing). - Similarly, tapping a mastered weapon also does nothing. If it's a generic weapon, maybe show the small illustration of it? - The ability to use healing consumables on combat sections (before combat) is questionable. Both Seventh Sense and Lone Wolf Saga forbid all consumable use until after combat has finished, except CS-boosting items like Alether (one dose of which is allowed before combat). It's a strict interpretation of the rules, but I find it to be a fair judgement. - Losing money or paying for things should deduct the proper amount immediately after pushing the button, but instead it only occurs when moving to the next section. See (21:127, 219) for examples. - In book 26-28, using the Obhanthor from the inventory menu worked as described. However, you can't use it during a section meal requirement. Maybe add the Obhanthor to the meal list (followed by the list of which meal to use it on)? - It appears many items have description text in the inventory, yet many others do not. Temujin's Ring, for example, has no description. It could say something like "plain ring made of petrified wood" and/or "given by the eponymous seer". - All of the small illustrations during pre-book setup (namely, the GM Disciplines, the Grand Weaponmastery chart, and equipment choices) are missing.
Section-Specific Issues (21:30) The stolen backpack item was not deducted from the inventory. (21:102) There is a slight grammatical error on the button to acquire the ring: there should not be a "the" preceeding Temujin's Ring. (21:101, 244) Arrows were deducted in these sections but it would make more sense to do so in the following sections (ie, after they have been fired). (21:174) This riddle may not be solvable with the app unless there's a clue in the pre-book setup or section 1. However, I didn't realize there is a "Hint" button until much later in the series. I imagine this particular hint gave the number of miles, but I cannot confirm this. (22:137) In the second option button's text, the ampersand's XML code appears instead of the symbol. (23:120) The Ivory Comb is listed twice among the items to sell. Is it possible to have two by this point? (23:224) The backpack item was not deducted upon moving to the next section. (23:59) In the first option button's text, the ampersand's XML code appears instead of the symbol. (23:46) The small illustration for this section is present, but the large illustration is missing. (24:162) Although the text forbids it, I was able to use Grand Huntmastery for a meal. (26:139) Although they seem to be red herrings, the Shovel and Pick should be lootable since they are capitalized. (26:206) Immediately after acquiring the Ashexa in section 206, but before moving to 77, the inventory description of it stated the Herbmastery rank bonus by default. I did possess the required rank to go to section 77, but please check the item functionality and description if a player is lacking the higher rank. (26:77) The "choose items" button should be disabled if you already acquired the Ashexa in the previous section. It was enabled and led to a blank item list. (27:80) I was unable to take the Rens, the button seemed to do nothing. (27:181) It would make more sense if any Ren you have were put towards the balance first (the app removed my Gold Crowns and no Ren was spent). (28:87) I used a laumspur potion to free up backpack space for the new items, but it did not restore EP immediately. Only upon moving to the next section did it take effect.
|
|
|
Post by t0pel on Oct 10, 2019 17:44:42 GMT
@ofecks Thank you for your super detailed report! Are you working as a software tester? If not, you should consider it! I will go through the list, post my response, and then start working on the fixes, but I will be super busy for the next few weeks, so it might take a while. Thank you again.
|
|
|
Post by Ofecks on Oct 10, 2019 18:52:01 GMT
Thanks, I have some experience in software development, but that was a long time ago. I've been told that I have an acute attention to detail.
Also, I edited my post with something I neglected to mention under Other General Issues - the missing small illustrations for the GM Disciplines, Grand Weaponmastery chart, and equipment choices.
|
|
|
Post by t0pel on Oct 31, 2019 21:44:55 GMT
Hi Ofecks, I am starting to go through the list. I have a question about the Sunstrike bonus issues you are having. My best guess is that the bonus does not get removed after some initial fight and it gets saved to the database. However, I am unable to reproduce this. Could you please provide additional information? - Is the bonus present all the time, even when you just view your stats outside of a fight?
- Does this mean that when you are in a fight, you have two +1 bonuses with the same name listed?
- Can you reproduce this issue with a new profile? If so, could you please provide the exact step?
Btw, for the Kai Weapon bonuses, I am mainly using information from the Lone Wolf wiki. Thanks a lot for your help. I am going through other issues mentioned in your post, I should be able to fix most of them fairly quickly, but some will require more effort.
|
|
|
Post by Ofecks on Nov 1, 2019 17:34:22 GMT
Is the bonus present all the time, even when you just view your stats outside of a fight? Yes, that's correct. Yes, correct as well. But not all of the time. During nighttime fights which are correctly flagged according to the section context, it only appears the once. I will give it a try and get back to you later.
|
|
|
Post by Ofecks on Nov 5, 2019 22:56:09 GMT
New post for bug reproduction request. Can you reproduce this issue with a new profile? If so, could you please provide the exact step? Rolled a fresh character on a new profile. Started with book 21. Picked G Weaponmastery, G Huntmastery, Kai-Surge, and Kai-Alchemy. Got Bow, Quiver, Sword, Meal, Laumspur and Sunstrike from Equipment. Sunstrike worked correctly for the first combat (giant spider), but for the second combat (Dar-Isun) I missed the bow shot and had to do the first round unarmed, yet I received the +1 daylight bonus anyway. Re-equipping Sunstrike for the 2nd round added the duplicate +1 daylight bonus for the rest of the combat. Once it was over, a +1 then showed up in the non-combat stats menu (I checked the first few sections of the book and that was not there before). The next combat (slave trader's henchmen) had a double daylight bonus. And the next one (Dromodon) only had one. I'm pretty sure this fight takes place at daytime so I'm guessing Sunstrike is not working correctly here. I did not make it past the Deathstalker, but there was a +1 daylight bonus for that fight (just the one) even though it's nighttime. That's all I have for you at this moment. My best guess would be the Dar-Isun fight mechanics, having to fight the first round unarmed and then re-equipping Sunstrike made something go wrong. I guess any other fight where you have to fight rounds unarmed (during daytime?) would cause the same program behavior, but I'm not sure where any of those fights are besides Dar-Isun.
|
|
|
Post by t0pel on Nov 10, 2019 9:50:29 GMT
Ofecks , thanks again for your help, I have just released an update that fixes a lot of the issues that you have reported. The update does the following: • Adds section text with item lists • Fixes bug with potential permanent Kai Weapon bonus in sections where the fight starts unarmed • Fixes bug with discipline usage not being forced in sections not offering a choice • Removes Project Aon footnote numbers from text • Fixes typo in the dialog when dropping an item • Fixes item ordering not being updated when dropping an item • Fixes bugs with an incorrectly displayed ampersand • Allows usage of Obhantor and Venell from the meal choice menu • Adds missing illustrations • Adds notification when there is not enough belt pouch space remaining • Fixes multiple bugs in specific sections Sorry about the forced usage of disciplines, but that is a major bug in my app, that was never my intention, I am not sure when did it start behaving like that, must be because of some other change I have made. Unless you are told that you can choose, you should be forced to use the discipline/item/payment. I will fix that. I will add the current behaviour as part of a custom ruleset in the future, where you could specify how strict you want this rule to be. Most of the things I have fixed, so I will not list them here. Some things I have not implemented either because I want to get the easy bug fixes out first, or because it is not possible right now.
Safekeeping | Future update | Italicised Kai-Alchemy | Not easily doable with current version of the framework I am using | Buy/sell/acquire interface do not indicate Special Item status | Not sure where to put this info, the description is already cramped, will try and do it in a future update | Tapping discipline/weapon to show info | Future update | Healing consumables on combat sections | Will add as a custom rule in a future update | More item descriptions | A lot of work – future update | 21:101, 244 – arrows deduction | Not easy to implement given my code design, might add it in the future | 26:139 – Shovel and Pick should be lootable | There are no instructions to indicate these items can be taken other than the capitalization, does not seem worth the trouble to add them | 26:206 – Ashexa description | This is working as intended, the description is generated based on your rank when you obtain the item | 27:80 – I was unable to take the Rens, the button seemed to do nothing | The button is working fine for me, is it possible you did not have enough room in the pouch? I have added a notification when there is not enough room left | 27:181 – split payment between remaining Rens and Gold | This is a good idea, but it will not be easy to implement, will try and add it in a future update |
|
|
|
Post by Ofecks on Nov 10, 2019 21:14:21 GMT
Unless you are told that you can choose, you should be forced to use the discipline/item/payment. I will fix that. I will add the current behaviour as part of a custom ruleset in the future, where you could specify how strict you want this rule to be. Ok, well, I disagree, but thanks for making sure the current implementation is possible later. I wanted to argue that it is the "correct" way to play, and went searching through the LW Club Newsletters to find exactly where Dever said you can always choose not to use disciplines or items... but I'm trying to avoid a certain illustration of Chalk's at all costs as it really freaks me out and quickly scrolling through the PDF, I caught a glimpse of it so NOPE. Possible, but I'm fairly certain I redundantly checked the current capacity and concluded it was a bug. The notification of a full pouch is a good addition, though.
|
|